-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate and cleanup OC.L10N
in favor of @nextcloud/l10n
#36287
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
core/src/OC/l10n.js
Outdated
* @deprecated 26.0.0 use `_unregister` from https://www.npmjs.com/package/@nextcloud/l10n | ||
*/ | ||
_unregister: unregisterAppTranslations, | ||
_unregister, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it a private method? Then it should not be exposed or it should be made public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is currently only used in CI tests, but I do not see a reason why this function should not be on the public API.
Maybe we should change this on the @nextcloud/l10n
package.
But for this PR I wanted to keep the changes small and do not introduce a breaking API change.
a9a2799
to
1705765
Compare
/compile |
Rebased onto current master |
Blocked by nextcloud-libraries/nextcloud-l10n#571 (and we need to wait for a new release) |
2437eba
to
5a11c08
Compare
…C app Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
5a11c08
to
ffeabde
Compare
/compile |
…nextcloud/l10n` Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
…ymore Meaning we can not stub `getLocale` but must override the document attribute instead. Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
23fea27
to
c97137e
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
The drone CI failure on the mysql DB tests seem unrelated. |
Summary
This PR consists of three parts:
OC
:OC.addTranslations
was deprecated with NC17 and is not used anymore by any app within the github nextcloud organizationOC.getLocale
andOC.getLanguage
as they are provided by@nextcloud/l10n
and drop duplicated code@nextcloud/l10n
.Checklist
OC.addTranslations
to NC26 upgrade guide documentation#9575 (upgrade guide)