Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop bootstrap #36434

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Drop bootstrap #36434

merged 3 commits into from
Jan 30, 2023

Conversation

nickvergessen
Copy link
Member

  • Resolves: #

Summary

TODO

  • ...

Checklist

@nickvergessen nickvergessen added this to the Nextcloud 26 milestone Jan 30, 2023
@nickvergessen nickvergessen self-assigned this Jan 30, 2023
artonge
artonge approved these changes Jan 30, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't see any breakage from a very light test

@juliushaertl
Copy link
Member

Haven't tested yet, but as far as I remember it was only used for tooltips which might already have been migrated away to use browser-native ones.

ChristophWurst
ChristophWurst approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🫡

@nickvergessen
Remove bootstrap dependency
b4f4e19 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Remove usages of bootstrap
04e1e2f 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Recompile
5b5bc71 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label Jan 30, 2023
@nickvergessen nickvergessen merged commit e4fadcf into master Jan 30, 2023
@nickvergessen nickvergessen deleted the techdebt/noid/drop-bootstrap branch January 30, 2023 22:13
@nickvergessen nickvergessen mentioned this pull request Jan 31, 2023
Closed
@blizzz blizzz mentioned this pull request Feb 1, 2023
Merged
@DaphneMuller
Copy link

hello @nickvergessen
Thank you so much for your work on this pull request! This ticket seems to have the tag 'pending documentation'.
Is there any chance you could clarify what documentation is missing? Is this for admins or for app developers?

@nickvergessen
Copy link
Member Author

Was added in #34692 (comment)

@nickvergessen nickvergessen removed the pending documentation This pull request needs an associated documentation update label Feb 21, 2023
@skjnldsv skjnldsv mentioned this pull request Apr 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug feature: dependencies
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
6 participants
@nickvergessen @juliushaertl @DaphneMuller @ChristophWurst @artonge @Pytal