Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3rdparty] Bump sabre/dav to 3.2.2 #3648

Merged
merged 3 commits into from
Mar 13, 2017
Merged

[3rdparty] Bump sabre/dav to 3.2.2 #3648

merged 3 commits into from
Mar 13, 2017

Conversation

rullzer
Copy link
Member

@rullzer rullzer commented Feb 28, 2017 •
edited
Loading

Depends on

Lets see what CI thinks

@rullzer rullzer added the 3. to review Waiting for reviews label Feb 28, 2017
@rullzer rullzer added this to the Nextcloud 12.0 milestone Feb 28, 2017
LukasReschke
LukasReschke requested changes Feb 28, 2017
View reviewed changes
Copy link
Member

@LukasReschke LukasReschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need an adjustment :)

MorrisJobke
MorrisJobke requested changes Feb 28, 2017
View reviewed changes
Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploading Bildschirmfoto 2017-02-28 um 12.31.09.png…

tags integration tests fail

@rullzer
Copy link
Member Author

rullzer commented Feb 28, 2017

Tags test pass.

@rullzer rullzer force-pushed the sabre-3.2.2 branch 4 times, most recently from 6ccb24c to a97ccbc Compare March 6, 2017 20:59
@rullzer rullzer force-pushed the sabre-3.2.2 branch 2 times, most recently from 8a21bfb to 53bce7c Compare March 10, 2017 07:20
@rullzer
[3rdparty] Bump sabre/dav to 3.2.2
8a8df60 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Fix tests
5c2772f 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Make intergration tests work again
e8ac348 
The regex was to greedy

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
@rullzer
Copy link
Member Author

rullzer commented Mar 10, 2017

3rdparty merged. Rebased this.

ChristophWurst
ChristophWurst approved these changes Mar 13, 2017
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from three timeouts all tests are green, changes look good, my local instance still seems to work -> LGTM :-)

@LukasReschke LukasReschke merged commit 756bc90 into master Mar 13, 2017
@LukasReschke LukasReschke deleted the sabre-3.2.2 branch March 13, 2017 18:27
@MorrisJobke MorrisJobke mentioned this pull request May 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MorrisJobke MorrisJobke MorrisJobke requested changes

@LukasReschke LukasReschke LukasReschke approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 12.0
Development

Successfully merging this pull request may close these issues.
4 participants
@rullzer @MorrisJobke @LukasReschke @ChristophWurst