Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(caldav): Correctly handle calendar recreation for invitations when the current calendar is in the trashbin #36594

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

tcitworld
Copy link
Member

@tcitworld tcitworld commented Feb 7, 2023

Follow-up to #32361, closes nextcloud/calendar#4098

TODO

  • fix tests

Checklist

@tcitworld tcitworld added the 2. developing Work in progress label Feb 7, 2023
@tcitworld tcitworld added this to the Nextcloud 26 milestone Feb 7, 2023
@tcitworld tcitworld self-assigned this Feb 7, 2023
…n the current calendar is in the trashbin

Follow-up to #32361, see nextcloud/calendar#4098 for details

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld marked this pull request as ready for review February 9, 2023 13:43
@tcitworld tcitworld added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 9, 2023
@tcitworld tcitworld requested review from st3iny, ChristophWurst, miaulalala, a team, ArtificialOwl, icewind1991 and blizzz and removed request for ChristophWurst, miaulalala and a team February 9, 2023 13:44
Copy link
Contributor

@miaulalala miaulalala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works.

@st3iny
Copy link
Member

st3iny commented Mar 2, 2023

@tcitworld This PR fully addresses nextcloud/calendar#4098, right? We should link the issue then.

@st3iny st3iny added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Mar 2, 2023
@blizzz
Copy link
Member

blizzz commented Mar 2, 2023

Cypress errors seem unrelated, merging.

@blizzz blizzz merged commit e08fa78 into master Mar 2, 2023
@blizzz blizzz deleted the fix-handling-of-invitations branch March 2, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish bug feature: caldav Related to CalDAV internals feature: dav
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calendar invitations end up in the trash bin, if the personal calendar had been deleted
5 participants