Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly test and log when a group is not found #36784

Merged
merged 1 commit into from
Apr 24, 2023
Merged

Properly test and log when a group is not found #36784

merged 1 commit into from
Apr 24, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Feb 20, 2023 •
edited
Loading

Summary

Avoid an error about passing null instead of IGroup to the event
constructor, instead skip the failed group and log the problem.

Checklist

@come-nc
Properly test and log when a group is not found
0186194 
Avoid an error about passing null instead of IGroup to the event
 constructor, instead skip the failed group and log the problem.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added the 3. to review Waiting for reviews label Feb 20, 2023
@come-nc come-nc added this to the Nextcloud 26 milestone Feb 20, 2023
@come-nc come-nc self-assigned this Feb 20, 2023
@come-nc come-nc added the bug label Feb 20, 2023
@come-nc come-nc requested review from blizzz, a team, ArtificialOwl and icewind1991 and removed request for a team February 20, 2023 16:37
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 7, 2023
Merged
@blizzz blizzz modified the milestones: Nextcloud 26, Nextcloud 27 Mar 7, 2023
@kesselb kesselb merged commit 2abefff into master Apr 24, 2023
@kesselb kesselb deleted the fix/user_ldap-update-groups-fail-get branch April 24, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@max-nextcloud max-nextcloud max-nextcloud approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@come-nc @kesselb @max-nextcloud @blizzz