Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid extra parenthesis around SQL in IN expressions #36795

Merged
merged 1 commit into from
Feb 21, 2023
Merged

Avoid extra parenthesis around SQL in IN expressions #36795

merged 1 commit into from
Feb 21, 2023

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Feb 21, 2023 •
edited
Loading

Summary

The expression builder already suround the SQL with parenthesis when
using in(), so we must not add another pair, this confuses at least
sqlite.

Checklist

@come-nc come-nc added the 3. to review Waiting for reviews label Feb 21, 2023
@come-nc come-nc added this to the Nextcloud 26 milestone Feb 21, 2023
@come-nc come-nc self-assigned this Feb 21, 2023
@come-nc
Copy link
Contributor Author

come-nc commented Feb 21, 2023

Follow up of nextcloud/spreed#8220 (comment)

@come-nc
Copy link
Contributor Author

come-nc commented Feb 21, 2023

/backport to stable25

@come-nc
Copy link
Contributor Author

come-nc commented Feb 21, 2023

/backport to stable24

@come-nc come-nc linked an issue Feb 21, 2023 that may be closed by this pull request
Subquery inside IN must not use additional () on the createFunction() call or it breaks in SQLite #34836
Closed
@come-nc come-nc requested review from a team, ArtificialOwl, icewind1991 and blizzz and removed request for a team February 21, 2023 11:19
@come-nc come-nc added the bug label Feb 21, 2023
@come-nc
Copy link
Contributor Author

come-nc commented Feb 21, 2023

/rebase

@come-nc
Avoid extra parenthesis around SQL in IN expressions
7481181 
The expression builder already suround the SQL with parenthesis when
 using in(), so we must not add another pair, this confuses at least
 sqlite.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/remove-erronous-parentheses-in-in-clause branch from 9319224 to 7481181 Compare February 21, 2023 13:37
@come-nc come-nc merged commit 18c4761 into master Feb 21, 2023
@come-nc come-nc deleted the fix/remove-erronous-parentheses-in-in-clause branch February 21, 2023 16:37
This was referenced Feb 21, 2023
Merged
Merged
@skjnldsv skjnldsv mentioned this pull request Feb 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@icewind1991 icewind1991 icewind1991 approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

@vitormattos vitormattos Awaiting requested review from vitormattos

Assignees

@come-nc come-nc

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

Subquery inside IN must not use additional () on the createFunction() call or it breaks in SQLite
3 participants
@come-nc @nickvergessen @icewind1991