fix(caldav): convert iMip recipient name to a string

[st3iny]

• Resolves: [Bug]: iMip Email: Invalid type of recipient name parameter #36897
• (Possible) Regression of: Include more information in iMIP email and show diff information on updating an event #35743 (backports are still pending!)

Summary

The recipient name is expected to be a string or null. Before this PR, it was a Sabre\VObject\Parameter so we need to convert it to a string.

The \Sabre\VObject\ITip\Message::$recipientName property should be string or null and is wrongly annotated upstream (in Sabre).

    /**
     * The name of the recipient. This is usually populated with the CN
     * parameter from the ATTENDEE or ORGANIZER property, if it's available.
     *
     * @var string|null
     */
    public $recipientName;

TODO

• Trigger backports when backports of Include more information in iMIP email and show diff information on updating an event #35743 were merged

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[nickvergessen]

Applied on our instance

[nickvergessen]

Now errors a bit further down, as it assumes $this->userId would be set.

{
  "reqId": "aYk6tC4vpMagsgJaEjAU",
  "level": 3,
  "time": "2023-03-01T08:04:12+00:00",
  "remoteAddr": "2a02:…",
  "user": "…",
  "app": "webdav",
  "method": "PUT",
  "url": "/remote.php/dav/calendars/…/…/cf33c5ec-….ics",
  "message": "OC\\User\\Manager::getDisplayName(): Argument #1 ($uid) must be of type string, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php on line 213",
  "userAgent": "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0",
  "version": "26.0.0.7",
  "exception": {
    "Exception": "TypeError",
    "Message": "OC\\User\\Manager::getDisplayName(): Argument #1 ($uid) must be of type string, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php on line 213",
    "Code": 0,
    "Trace": [
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php",
        "line": 213,
        "function": "getDisplayName",
        "class": "OC\\User\\Manager",
        "type": "->",
        "args": [
          null
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
        "line": 89,
        "function": "schedule",
        "class": "OCA\\DAV\\CalDAV\\Schedule\\IMipPlugin",
        "type": "->",
        "args": [
          [
            "Sabre\\VObject\\ITip\\Message",
            "cf33c5ec-…",
            "VEVENT",
            "REQUEST",
            1,
            "mailto:f…",
            null,
            "mailto:s…",
            null,
            "1.2;Message delivered locally",
            [
              "Sabre\\VObject\\Component\\VCalendar",
              null,
              "VCALENDAR"
            ],
            true
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Schedule/Plugin.php",
        "line": 350,
        "function": "emit",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "schedule",
          [
            [
              "Sabre\\VObject\\ITip\\Message",
              "cf33c5ec-…",
              "VEVENT",
              "REQUEST",
              1,
              "mailto:f…",
              null,
              "mailto:s…",
              null,
              "1.2;Message delivered locally",
              [
                "Sabre\\VObject\\Component\\VCalendar",
                null,
                "VCALENDAR"
              ],
              true
            ]
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Schedule/Plugin.php",
        "line": 627,
        "function": "deliver",
        "class": "Sabre\\CalDAV\\Schedule\\Plugin",
        "type": "->",
        "args": [
          [
            "Sabre\\VObject\\ITip\\Message",
            "cf33c5ec-…",
            "VEVENT",
            "REQUEST",
            1,
            "mailto:f…",
            null,
            "mailto:s…",
            null,
            "1.2;Message delivered locally",
            [
              "Sabre\\VObject\\Component\\VCalendar",
              null,
              "VCALENDAR"
            ],
            true
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Schedule/Plugin.php",
        "line": 337,
        "function": "processICalendarChange",
        "class": "Sabre\\CalDAV\\Schedule\\Plugin",
        "type": "->",
        "args": [
          null,
          [
            "Sabre\\VObject\\Component\\VCalendar",
            null,
            "VCALENDAR"
          ],
          [
            "mailto:f…",
            "/remote.php/dav/principals/users/…/"
          ],
          [],
          true
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/apps/dav/lib/CalDAV/Schedule/Plugin.php",
        "line": 165,
        "function": "calendarObjectChange",
        "class": "Sabre\\CalDAV\\Schedule\\Plugin",
        "type": "->",
        "args": [
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ],
          [
            "Sabre\\VObject\\Component\\VCalendar",
            null,
            "VCALENDAR"
          ],
          "calendars/…/…",
          true,
          true
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
        "line": 89,
        "function": "calendarObjectChange",
        "class": "OCA\\DAV\\CalDAV\\Schedule\\Plugin",
        "type": "->",
        "args": [
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ],
          [
            "Sabre\\VObject\\Component\\VCalendar",
            null,
            "VCALENDAR"
          ],
          "calendars/…/…",
          true,
          true
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Plugin.php",
        "line": 897,
        "function": "emit",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "calendarObjectChange",
          [
            [
              "Sabre\\HTTP\\Request"
            ],
            [
              "Sabre\\HTTP\\Response"
            ],
            [
              "Sabre\\VObject\\Component\\VCalendar",
              null,
              "VCALENDAR"
            ],
            "calendars/…/…",
            true,
            "And 1 more entries, set log level to debug to see all entries"
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/CalDAV/Plugin.php",
        "line": 766,
        "function": "validateICalendar",
        "class": "Sabre\\CalDAV\\Plugin",
        "type": "->",
        "args": [
          "BEGIN:VCALENDAR\r\n…",
          "calendars/…/…/cf33c5ec-….ics",
          false,
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ],
          true
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
        "line": 89,
        "function": "beforeCreateFile",
        "class": "Sabre\\CalDAV\\Plugin",
        "type": "->",
        "args": [
          "calendars/…/…/cf33c5ec-….ics",
          "BEGIN:VCALENDAR\r\nPRODID…",
          [
            "OCA\\DAV\\CalDAV\\Calendar"
          ],
          false
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 1094,
        "function": "emit",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "beforeCreateFile",
          [
            "calendars/…/…/cf33c5ec-….ics",
            "BEGIN:VCALENDAR\r\nPRODID…",
            [
              "OCA\\DAV\\CalDAV\\Calendar"
            ],
            false
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/DAV/CorePlugin.php",
        "line": 504,
        "function": "createFile",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "calendars/…/…/cf33c5ec-….ics",
          "BEGIN:VCALENDAR\r\nPRODID…",
          null
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/event/lib/WildcardEmitterTrait.php",
        "line": 89,
        "function": "httpPut",
        "class": "Sabre\\DAV\\CorePlugin",
        "type": "->",
        "args": [
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 472,
        "function": "emit",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          "method:PUT",
          [
            [
              "Sabre\\HTTP\\Request"
            ],
            [
              "Sabre\\HTTP\\Response"
            ]
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 253,
        "function": "invokeMethod",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": [
          [
            "Sabre\\HTTP\\Request"
          ],
          [
            "Sabre\\HTTP\\Response"
          ]
        ]
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/3rdparty/sabre/dav/lib/DAV/Server.php",
        "line": 321,
        "function": "start",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/apps/dav/lib/Server.php",
        "line": 363,
        "function": "exec",
        "class": "Sabre\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/apps/dav/appinfo/v2/remote.php",
        "line": 35,
        "function": "exec",
        "class": "OCA\\DAV\\Server",
        "type": "->",
        "args": []
      },
      {
        "file": "/var/www/cloud.nextcloud.com/nextcloud/remote.php",
        "line": 171,
        "args": [
          "/var/www/cloud.nextcloud.com/nextcloud/apps/dav/appinfo/v2/remote.php"
        ],
        "function": "require_once"
      }
    ],
    "File": "/var/www/cloud.nextcloud.com/nextcloud/lib/private/User/Manager.php",
    "Line": 193,
    "message": "OC\\User\\Manager::getDisplayName(): Argument #1 ($uid) must be of type string, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php on line 213",
    "exception": {},
    "CustomMessage": "OC\\User\\Manager::getDisplayName(): Argument #1 ($uid) must be of type string, null given, called in /var/www/cloud.nextcloud.com/nextcloud/apps/dav/lib/CalDAV/Schedule/IMipPlugin.php on line 213"
  }
}