Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): logo missing on login page #36930

Merged
merged 1 commit into from
Mar 1, 2023
Merged

fix(theming): logo missing on login page #36930

merged 1 commit into from
Mar 1, 2023

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Mar 1, 2023

Missing from revert of #35071
Fix #36540

Before After
localhost_8080_index php_login_redirect_url=index php_apps_dashboard (1) localhost_8080_index php_login_redirect_url=index php_apps_dashboard

Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@skjnldsv skjnldsv added bug design Design, UI, UX, etc. 3. to review Waiting for reviews feature: theming regression labels Mar 1, 2023
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Mar 1, 2023
@skjnldsv skjnldsv requested review from JuliaKirschenheuter, Pytal and a team March 1, 2023 07:32
@skjnldsv skjnldsv self-assigned this Mar 1, 2023
@skjnldsv skjnldsv requested review from artonge and szaimen and removed request for a team March 1, 2023 07:32
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! :)

@skjnldsv skjnldsv merged commit d213105 into master Mar 1, 2023
@skjnldsv skjnldsv deleted the fix/logoheader branch March 1, 2023 08:10
@blizzz blizzz mentioned this pull request Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Design/Theming: Uploaded logo not shown on Login page (on a NEW 26.0.0beta2 install)
3 participants