Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix share select dropdown not opening when viewer is open #36998

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fix share select dropdown not opening when viewer is open #36998

merged 1 commit into from
Mar 2, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Mar 2, 2023 •
edited
Loading

Reproduction

  1. Navigate to files
  2. Open a file in viewer
  3. Click the share select

Expected: Dropdown opens

Actual: Dropdown stays closed

Summary

Before After
image image

Note: Unrelated focused border styles bug to be fixed separately

Checklist

@Pytal
Fix share select dropdown not opening when viewer is open
0c69619 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added this to the Nextcloud 26 milestone Mar 2, 2023
@Pytal Pytal self-assigned this Mar 2, 2023
@Pytal
Copy link
Member Author

Pytal commented Mar 2, 2023

/backport to stable25

JuliaKirschenheuter
JuliaKirschenheuter approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works! Thanks for fixing

@juliushaertl juliushaertl mentioned this pull request Mar 2, 2023
Closed
@juliushaertl

This comment was marked as outdated.

Sign in to view
@skjnldsv skjnldsv merged commit 2f64d16 into master Mar 2, 2023
@skjnldsv skjnldsv deleted the fix/share-select-viewer branch March 2, 2023 08:31
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 2, 2023
Merged
1 task
@blizzz blizzz mentioned this pull request Mar 2, 2023
Merged
@ShGKme ShGKme mentioned this pull request Sep 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@artonge artonge Awaiting requested review from artonge

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews bug feature: sharing
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @juliushaertl @JuliaKirschenheuter @skjnldsv