Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Stable9] Make theming work with pretty URLs #370

Merged
merged 2 commits into from
Jul 12, 2016
Merged

[Stable9] Make theming work with pretty URLs #370

merged 2 commits into from
Jul 12, 2016

Conversation

oparoz
Copy link
Member

@oparoz oparoz commented Jul 11, 2016 •
edited
Loading

oparoz added 2 commits July 11, 2016 17:42
Make theming work with pretty URLs
1f28ed8 
In some envs the rewrite rules for pretty URLs apply to all CSS files, so let's not end the route name with that etension.
Fixes #315
(cherry picked from commit 839ee5e)
Fix tests
3c0ba18 
(cherry picked from commit eceb0db)
@oparoz oparoz added bug 3. to review Waiting for reviews labels Jul 11, 2016
@oparoz oparoz added this to the Nextcloud 9.0.53 milestone Jul 11, 2016
@oparoz oparoz self-assigned this Jul 11, 2016
@mention-bot
Copy link

@oparoz, thanks for your PR! By analyzing the annotation information on this pull request, we identified @schiessle and @LukasReschke to be potential reviewers

@oparoz oparoz mentioned this pull request Jul 11, 2016
Merged
@LukasReschke
Copy link
Member

LGTM. Thanks @oparoz 🚀

@MariusBluem
Copy link
Member

Let's do this 👍

@MariusBluem MariusBluem merged commit d35d9d2 into stable9 Jul 12, 2016
@MariusBluem MariusBluem deleted the stable9-backport-361 branch July 12, 2016 04:59
@LukasReschke LukasReschke mentioned this pull request Jul 14, 2016
Closed
@oparoz oparoz removed the 3. to review Waiting for reviews label Aug 12, 2016
@blizzz blizzz mentioned this pull request Jun 17, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@oparoz oparoz

Labels
bug
Projects
None yet
Milestone
Nextcloud 9.0.54
Development

Successfully merging this pull request may close these issues.
4 participants
@oparoz @mention-bot @LukasReschke @MariusBluem