Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit "Accessing site insecurely via HTTP." warning if HTTP is secure enough #37330

Merged
merged 2 commits into from
Apr 18, 2023
Merged

Omit "Accessing site insecurely via HTTP." warning if HTTP is secure enough #37330

merged 2 commits into from
Apr 18, 2023

Conversation

Al2Klimov
Copy link
Contributor

@Al2Klimov Al2Klimov commented Mar 21, 2023 •
edited by solracsf
Loading

Summary

This is the case for localhost and Tor hidden services.

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Mar 23, 2023
@solracsf solracsf added this to the Nextcloud 27 milestone Mar 23, 2023
@szaimen szaimen requested review from a team, artonge, skjnldsv and Pytal and removed request for a team March 23, 2023 08:13
@Al2Klimov
Copy link
Contributor Author

Cool that you consider this for NC 27. #37330 (comment)

But IMAO there’s some a little more important of mine, a literal security hole IMAO:

artonge
artonge approved these changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@artonge artonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense

@Pytal
Copy link
Member

Pytal commented Apr 4, 2023

/rebase

@Al2Klimov @szaimen
Omit "Accessing site insecurely via HTTP." warning if HTTP is secure …
e3f1fae 
…enough

This is the case for localhost and Tor hidden services.

Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
@Al2Klimov @szaimen
Drop broken unit test
ff02b07 
Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
@szaimen szaimen enabled auto-merge April 17, 2023 21:39
@szaimen szaimen merged commit e10e509 into nextcloud:master Apr 18, 2023
@Al2Klimov Al2Klimov deleted the http-enough branch April 18, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@Pytal Pytal Pytal approved these changes

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
5 participants
@Al2Klimov @Pytal @artonge @solracsf @szaimen