Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(mailer): remove value comparison for smtp_authtype as there is only one option #37340

Merged
merged 1 commit into from
Mar 24, 2023
Merged

fix(mailer): remove value comparison for smtp_authtype as there is only one option #37340

merged 1 commit into from
Mar 24, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Mar 22, 2023 •
edited
Loading

Summary

The mail_smtpauth parameter is never passed to the template and thus always 0. There is only the LOGIN option anyway so I removed the check completely.

Checklist

@miaulalala miaulalala added this to the Nextcloud 27 milestone Mar 22, 2023
@miaulalala miaulalala requested review from juliushaertl, come-nc and a team March 22, 2023 11:41
@miaulalala miaulalala self-assigned this Mar 22, 2023
@miaulalala miaulalala requested review from ArtificialOwl and icewind1991 and removed request for a team March 22, 2023 11:41
@miaulalala
Copy link
Contributor Author

/backport to stable26

@bigcat88 bigcat88 self-requested a review March 22, 2023 11:58
@miaulalala miaulalala changed the title fix(mailer): add isset check on authentication parameter fix(mailer): remove value comparison for smtp_authtype as there is only one option Mar 22, 2023
@miaulalala miaulalala requested review from juliushaertl, bigcat88 and skjnldsv and removed request for juliushaertl March 22, 2023 12:10
@miaulalala miaulalala force-pushed the fix/undefined-index-mailer-settings branch from 56e315a to 4ff90f0 Compare March 22, 2023 13:37
@miaulalala miaulalala mentioned this pull request Mar 24, 2023
Merged
5 tasks
@miaulalala

This comment was marked as outdated.

Sign in to view
@szaimen
Copy link
Contributor

szaimen commented Mar 24, 2023

A rebase should fix it

@miaulalala
Copy link
Contributor Author

/rebase

@miaulalala
fix(mailer): check if authentication is neccessary
1368012 
Signed-off-by: Anna Larch <anna@nextcloud.com>
@nextcloud-command nextcloud-command force-pushed the fix/undefined-index-mailer-settings branch from 4ff90f0 to 1368012 Compare March 24, 2023 10:26
@szaimen
Copy link
Contributor

szaimen commented Mar 24, 2023

Cypress failure unrelated

@szaimen szaimen merged commit fda9d4d into master Mar 24, 2023
@szaimen szaimen deleted the fix/undefined-index-mailer-settings branch March 24, 2023 14:34
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Mar 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@come-nc come-nc Awaiting requested review from come-nc

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@bigcat88 bigcat88 Awaiting requested review from bigcat88

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees

@miaulalala miaulalala

Labels
3. to review Waiting for reviews 26-feedback feature: emails
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.

[Bug]: NEXTCLOUD 26 Email Setup no Test successfully
5 participants
@miaulalala @szaimen @juliushaertl @bigcat88 @skjnldsv