Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app type extended_authentication #37680

Merged
merged 1 commit into from
Apr 12, 2023

Conversation

ArtificialOwl
Copy link
Member

@ArtificialOwl ArtificialOwl commented Apr 11, 2023

globalsiteselector is a single app used in globalscale that redirect users and/or sessions from one instance (master) to another (slaves) while working with local account, ldap, sso and saml.

Some use-cases:

  • when using SAML, then authentication of the user is done on the master, a session is opened on the assigned slave and user is redirected. In that case, the globalsiteselector will comes with its own UserBackend that needs to be loaded soon enough in the process.
  • on some OCS API Request, the globalsiteselector app must be loaded before the files app
  • when using LDAP, the authentication is done on the slave. Based on the userid, the master will create a token with uid/password and redirect the user to the assigned slave. The slave will perform the authentication and user_ldap needs to be loaded before globalsiteselector

In conclusion, globalsiteselector needs to be loaded once all apps type=authentication are loaded and before type=filesystem

This fix creates a new type of apps for globalsiteselector that is loaded right after authentication.

@ArtificialOwl ArtificialOwl marked this pull request as ready for review April 12, 2023 09:50
@ArtificialOwl
Copy link
Member Author

/backport to stable26

@ArtificialOwl
Copy link
Member Author

/backport to stable25

Copy link
Member

@blizzz blizzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new type also to resources/app-info.xsd and resources/app-info-shipped.xsd (this will need a PR to the appstore as well)

@blizzz
Copy link
Member

blizzz commented Apr 12, 2023

Unsure about the name, it is not saying much, however to my mind nothing great is coming either. I could think of umbrella_authentication or catchall_authentication or supre_authentication but it is not necessarily better, latter might be confusing even. So, wording not a blocker, but open for improvements.

@ArtificialOwl
Copy link
Member Author

good luck with that :-D
extended_authentication already took me a while. But the more I see it, the more it makes sense for me (from the globalsiteselector point of view).

Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl ArtificialOwl force-pushed the enh/noid/add-app-type-extended-authentication branch from f06f5b7 to fc29b0d Compare April 12, 2023 10:35
@ArtificialOwl
Copy link
Member Author

Please add new type also to resources/app-info.xsd and resources/app-info-shipped.xsd (this will need a PR to the appstore as well)

done and squashed

@blizzz blizzz requested review from a team, icewind1991, skjnldsv and come-nc and removed request for a team April 12, 2023 10:42
@blizzz blizzz added the 3. to review Waiting for reviews label Apr 12, 2023
@blizzz blizzz added this to the Nextcloud 27 milestone Apr 12, 2023
@ArtificialOwl ArtificialOwl merged commit fe2e0a5 into master Apr 12, 2023
@ArtificialOwl ArtificialOwl deleted the enh/noid/add-app-type-extended-authentication branch April 12, 2023 14:22
@ChristophWurst ChristophWurst added the pending documentation This pull request needs an associated documentation update label May 31, 2023
@ChristophWurst
Copy link
Member

This change may affect app devs and should be documented

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews pending documentation This pull request needs an associated documentation update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants