Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(translation): Fix several issues with the translations api #37704

Merged
merged 4 commits into from
Apr 13, 2023
Merged

fix(translation): Fix several issues with the translations api #37704

merged 4 commits into from
Apr 13, 2023

Conversation

nickvergessen
Copy link
Member

TODO

  • Allow guests to use translations
  • Translate error messages so they can be shown in the UI
  • Fix status code set incorrectly
  • Fix status codes to be properly usable as an API

Checklist

@nickvergessen
fix(translation): Translate error messages on translations API
21b056e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(translation): Properly set the numbers as HTTP status code
b7c1e61 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
fix(translation): Use 400 as status code to be distinguishable from s…
032821d 
…erver errors

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
feat(translation): Allow guests to use translations as well
e5d0ff0 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added bug 3. to review Waiting for reviews labels Apr 13, 2023
@nickvergessen nickvergessen added this to the Nextcloud 27 milestone Apr 13, 2023
@nickvergessen nickvergessen self-assigned this Apr 13, 2023
@nickvergessen nickvergessen mentioned this pull request Apr 13, 2023
Merged
@skjnldsv skjnldsv disabled auto-merge April 13, 2023 08:48
@skjnldsv skjnldsv merged commit b3f59aa into master Apr 13, 2023
@skjnldsv skjnldsv deleted the bugfix/noid/fix-translations-api branch April 13, 2023 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

@juliushaertl juliushaertl juliushaertl approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews bug
Projects
None yet
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @marcelklehr @juliushaertl @skjnldsv