Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(events): Log deprecated events as debug, not info #37816

Merged
merged 1 commit into from
Apr 24, 2023
Merged

fix(events): Log deprecated events as debug, not info #37816

merged 1 commit into from
Apr 24, 2023

Conversation

ChristophWurst
Copy link
Member

Summary

There is nothing an admin can. So let's not log this with info level.

Checklist

@ChristophWurst
fix(events): Log deprecated events as debug, not info
ce71aa9 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@ChristophWurst ChristophWurst added the 3. to review Waiting for reviews label Apr 19, 2023
@ChristophWurst ChristophWurst added this to the Nextcloud 27 milestone Apr 19, 2023
@ChristophWurst ChristophWurst self-assigned this Apr 19, 2023
@ChristophWurst ChristophWurst mentioned this pull request Apr 19, 2023
Closed
szaimen
szaimen approved these changes Apr 19, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea! :)

@szaimen szaimen added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Apr 20, 2023
@ChristophWurst ChristophWurst merged commit dcde970 into master Apr 24, 2023
@ChristophWurst ChristophWurst deleted the fix/events/info-to-debug-log-legacy-events branch April 24, 2023 09:14
@szaimen
Copy link
Contributor

szaimen commented Apr 24, 2023

backports?

@ChristophWurst
Copy link
Member Author

Trigger them if you think they are save and necessary. I am hesitant with this type of change.

@szaimen
Copy link
Contributor

szaimen commented Apr 24, 2023

All right, fine for me to leave it like this for now 👍

@szaimen szaimen mentioned this pull request Apr 24, 2023
Closed
@joshtrichards joshtrichards mentioned this pull request Jun 5, 2023
Closed
@szaimen szaimen mentioned this pull request Jun 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Chartman123 Chartman123 Chartman123 approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@ChristophWurst ChristophWurst

Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
💌 📅 👥 Groupware team
Archived in project
Milestone
Nextcloud 27
Development

Successfully merging this pull request may close these issues.
3 participants
@ChristophWurst @szaimen @Chartman123