-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable version features again with S3 versioning #38794
Conversation
Signed-off-by: Benjamin Somers <bsomers@resel.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is support for deleting and labeling versions was added to files_versions_s3
?
Yes, it has been implemented by nextcloud/files_versions_s3#27 |
Awesome @bensmrs. Can you fix DCO ? |
Hmmm I have several affiliations and the one I signed with is really the one that should appear… Any way for you to force the DCO without me having to switch my main email on GitHub (and switching it back to the current one 😓)? |
@bensmrs You add other email addresses in GH without messing with your primary one: |
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Done @bensmrs, thanks a lot for pushing this !! 🎉 |
/backport to stable27 |
Summary
After nextcloud/files_versions_s3#28 is merged, we can enable version features with the S3 versioning backend again.