generate user themed favicon and touchicon

[szaimen]

The problem was that the color was not taken into account by the logic. So as soon as the icon is created and put into place in the theming directory, it gets never re-created by changing the color. My PR now takes the color of the icon into account by putting it into the file name. The same logic is alreaddy applied and funcitoning here:

server/apps/theming/lib/Controller/IconController.php

Lines 89 to 97 in 7afcc44

	$color = $this->themingDefaults->getColorPrimary();
	try {
	$iconFileName = $this->imageManager->getCachedImage('icon-' . $app . '-' . $color . str_replace('/', '_', $image));
	} catch (NotFoundException $exception) {
	$icon = $this->iconBuilder->colorSvg($app, $image);
	if ($icon === false || $icon === '') {
	return new NotFoundResponse();
	}
	$iconFileName = $this->imageManager->setCachedImage('icon-' . $app . '-' . $color . str_replace('/', '_', $image), $icon);

[szaimen]

/backport to stable27

[szaimen]

/backport to stable26

[szaimen]

/backport to stable25

[szaimen]

Could you describe why it was broken before and how your changes fix the problem? I am not familiar with this area of the server code

I adjusted the description

[ChristophWurst]

Makes sense

[szaimen]

Node failure unrelated