Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor "substr" calls in dav app to improve code readability #39214

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Refactor "substr" calls in dav app to improve code readability #39214

merged 1 commit into from
Feb 23, 2024

Conversation

shdehnavi
Copy link
Contributor

@shdehnavi shdehnavi commented Jul 7, 2023 •
edited
Loading

Summary

Replacing substr with str_starts_with and str_ends_with in the dav app to improve code readability

Checklist

@shdehnavi shdehnavi changed the title Refactors "substr" calls to improve code readability Refactor "substr" calls to improve code readability Jul 7, 2023
@shdehnavi shdehnavi changed the title Refactor "substr" calls to improve code readability Refactor "substr" calls in dav app to improve code readability Jul 7, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@miaulalala
Copy link
Contributor

/rebase

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@shdehnavi shdehnavi force-pushed the replace_substr_calls_in_dav_app branch from a85bafd to b131f16 Compare December 11, 2023 12:43
@shdehnavi
Copy link
Contributor Author

@blizzz All conflicts have been resolved, Could you merge this PR?

@shdehnavi @skjnldsv
Refactors "substr" calls to improve code readability
7bf31df 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@skjnldsv skjnldsv force-pushed the replace_substr_calls_in_dav_app branch from b131f16 to 7bf31df Compare February 23, 2024 14:54
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@skjnldsv skjnldsv merged commit b91fb12 into nextcloud:master Feb 23, 2024
150 of 158 checks passed
@shdehnavi shdehnavi deleted the replace_substr_calls_in_dav_app branch February 26, 2024 10:50
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@tcitworld tcitworld tcitworld approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
7 participants
@shdehnavi @miaulalala @ChristophWurst @tcitworld @blizzz @solracsf @skjnldsv