Refactor "substr" calls in files app to improve code readability #39215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shdehnavi
changed the title
nickvergessen
approved these changes
Jul 14, 2023
fsamapoor
approved these changes
Sep 27, 2023
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
fsamapoor
force-pushed
the
replace_substr_calls_in_files_app
branch
from
6526bab
to
df0a396
Compare
juliushaertl
approved these changes
Oct 11, 2023
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
|
Is there any update regarding this PR changes? |
Merged
skjnldsv
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replacing
substrwithstr_starts_within thefilesapp to improve code readabilityChecklist