Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor contactsinteraction app #39243

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Refactor contactsinteraction app #39243

merged 2 commits into from
Aug 29, 2023

Conversation

shdehnavi
Copy link
Contributor

Summary

The required adjustments have been made to the contactsinteraction app.

The improvements:

  • Adding return types
  • Adding types to properties
  • Adding throw types
  • Using PHP8's constructor property promotion

Checklist

@solracsf solracsf added this to the Nextcloud 28 milestone Jul 9, 2023
@solracsf solracsf added 3. to review Waiting for reviews technical debt labels Jul 9, 2023
@shdehnavi shdehnavi mentioned this pull request Jul 13, 2023
Merged
@kesselb kesselb force-pushed the refactor_contactsinteraction_app branch from 84e3719 to c9b2007 Compare August 24, 2023 14:22
kesselb
kesselb approved these changes Aug 24, 2023
View reviewed changes
Copy link
Contributor

@kesselb kesselb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🧹

@kesselb kesselb force-pushed the refactor_contactsinteraction_app branch from c9b2007 to bab4955 Compare August 28, 2023 12:11
@shdehnavi @kesselb
Refactor contactsinteraction app
e22742b 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@shdehnavi @kesselb
Make adjustments based on the psalm messages
e1b33e6 
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com>
@kesselb kesselb force-pushed the refactor_contactsinteraction_app branch from bab4955 to e1b33e6 Compare August 29, 2023 09:35
@AndyScherzinger AndyScherzinger merged commit ad56458 into nextcloud:master Aug 29, 2023
36 of 39 checks passed
@welcome
Copy link

welcome bot commented Aug 29, 2023

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@kesselb kesselb mentioned this pull request Aug 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kesselb kesselb kesselb approved these changes

@miaulalala miaulalala miaulalala approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

Assignees
No one assigned
Labels
3. to review Waiting for reviews technical debt
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
5 participants
@shdehnavi @kesselb @miaulalala @AndyScherzinger @solracsf