Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(profile): fix getUID on nullable user variable #39309

Merged
merged 1 commit into from
Jul 17, 2023
Merged

fix(profile): fix getUID on nullable user variable #39309

merged 1 commit into from
Jul 17, 2023

Conversation

tcitworld
Copy link
Member

Summary

As per method signature, $visitingUser is nullable, so we can't be sure calling getUid() on it will work.

Checklist

@tcitworld
fix(profile): fix getUID on nullable user variable
cd9dac1 
As per method signature, $visitingUser is nullable, so we can't be sure calling getUid() on it will
work.

Closes #35766

Signed-off-by: Thomas Citharel <tcit@tcit.fr>
@tcitworld tcitworld added bug 3. to review Waiting for reviews feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.) labels Jul 11, 2023
@tcitworld tcitworld added this to the Nextcloud 28 milestone Jul 11, 2023
@tcitworld tcitworld requested review from Pytal and a team July 11, 2023 12:44
@tcitworld tcitworld self-assigned this Jul 11, 2023
@tcitworld tcitworld requested review from ArtificialOwl, icewind1991 and come-nc and removed request for a team July 11, 2023 12:44
@tcitworld
Copy link
Member Author

/backport to stable27

@tcitworld
Copy link
Member Author

/backport to stable26

@tcitworld
Copy link
Member Author

/backport to stable25

@come-nc come-nc merged commit de4c219 into master Jul 17, 2023
36 checks passed
@come-nc come-nc deleted the bug/35766/fix-get-uid-on-nullable branch July 17, 2023 12:45
This was referenced Jul 17, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pytal Pytal Pytal approved these changes

@come-nc come-nc come-nc approved these changes

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

Assignees

@tcitworld tcitworld

Labels
3. to review Waiting for reviews bug feature: profile PRs or issues related to the Profile feature (e.g. Profile page, API, etc.)
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Call to a member function getUID() on null in file '/var/www/nextcloud/lib/private/Profile/ProfileManager.php'
3 participants
@tcitworld @Pytal @come-nc