fix(apps): Fix loading info.xml file #39490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ref: https://bugs.php.net/bug.php?id=62577 Signed-off-by: Joas Schilling <coding@schilljs.com>
This was referenced Jul 20, 2023
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -63,10 +63,10 @@ | |||
| libxml_use_internal_errors(true); | |||
| if ((PHP_VERSION_ID < 80000)) { | |||
| $loadEntities = libxml_disable_entity_loader(false); | |||
| $xml = simplexml_load_file($file); | |||
| $xml = simplexml_load_string(file_get_contents($file)); | |||
Check failure
Code scanning / Psalm
TaintedFile Error
| libxml_disable_entity_loader($loadEntities); | ||
| } else { | ||
| $xml = simplexml_load_file($file); | ||
| $xml = simplexml_load_string(file_get_contents($file)); |
Check failure
Code scanning / Psalm
TaintedFile Error
This was referenced Jul 20, 2023
marcelklehr
approved these changes
Jul 20, 2023
come-nc
approved these changes
Jul 20, 2023
blizzz
approved these changes
Jul 20, 2023
blizzz
added
4. to release
hoellen
added a commit
to hoellen/docker-nextcloud
that referenced
this pull request
Jul 25, 2023
Nextcloud now prevents loading external entities by using libxml_set_external_entity_loader. ref: nextcloud/server#39490 #42
hoellen
added a commit
to hoellen/docker-nextcloud
that referenced
this pull request
Jul 26, 2023
Nextcloud now prevents loading external entities by using libxml_set_external_entity_loader. ref: nextcloud/server#39490 #42
hoellen
added a commit
to hoellen/docker-nextcloud
that referenced
this pull request
Jul 26, 2023
Nextcloud now prevents loading external entities by using libxml_set_external_entity_loader. ref: nextcloud/server#39490 #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://bugs.php.net/bug.php?id=62577
Checklist