/ocs/v1.php/cloud/groups UPDATE method - correct status when group not found
#39537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
bigcat88
changed the title
/ocs/v1.php/cloud/groups UPDATE method - correct status when group not found
susnux
requested review from
a team,
ArtificialOwl,
icewind1991 and
Fenn-CS
and removed request for
a team
susnux
added
3. to review
Fenn-CS
reviewed
Jul 22, 2023
| @@ -271,6 +271,9 @@ public function updateGroup(string $groupId, string $key, string $value): DataRe | |||
|
|
|||
| if ($key === 'displayname') { | |||
| $group = $this->groupManager->get($groupId); | |||
| if ($group === null) { | |||
| throw new OCSException('Group does not exist', OCSController::RESPOND_NOT_FOUND); | |||
There was a problem hiding this comment.
Suggested change
| throw new OCSException('Group does not exist', OCSController::RESPOND_NOT_FOUND); | |
| throw new OCSException("Group $groupId does not exist", OCSController::RESPOND_NOT_FOUND); |
Is probably more helpful.
There was a problem hiding this comment.
But the caller already knows what group he requested to edit.
marcelklehr
approved these changes
Jul 24, 2023
julien-nc
approved these changes
Jul 24, 2023
|
/backport to stable27 |
|
/backport to stable26 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We should return
OCSController::RESPOND_NOT_FOUNDwhen something from input parameters not found and set text description what exactly was not found.Checklist