Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor files trashbin app #39883

Closed
wants to merge 14 commits into from
Closed

Refactor files trashbin app #39883

wants to merge 14 commits into from

Commits on Aug 16, 2023

  1. Files trashbin app: Return early in method retainVersions 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    558c146 View commit details
    Browse the repository at this point in the history

  2. Files trashbin app: Change the const name for more readability 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    81c4780 View commit details
    Browse the repository at this point in the history

  3. Files trashbin app: Adding functions' return type 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    2c298c0 View commit details
    Browse the repository at this point in the history

  4. Files trashbin app: Return early 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    36338e8 View commit details
    Browse the repository at this point in the history

  5. Files trashbin app: Remove extra spaces between methods 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    dfceb76 View commit details
    Browse the repository at this point in the history

  6. Files trashbin app: Update doc types 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    a531255 View commit details
    Browse the repository at this point in the history

  7. Files trashbin app: Add remaining return type. 

    Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    82dd6fa View commit details
    Browse the repository at this point in the history

  8. Files trashbin app: Add parameter type to the methods according to th… 

    …e psalm analysis

Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    8bd6a2f View commit details
    Browse the repository at this point in the history

  9. Files trashbin app: Remove unrelated throw tag for clarification exce… 

    …ption on doctype

Signed-off-by: Danial Rahimi <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy
    danialRahimy committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    dcfcce8 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2023

  1. Update apps/files_trashbin/lib/Trashbin.php 

    Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Signed-off-by: danial rahimy <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy @Fenn-CS
    danialRahimy and Fenn-CS authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    e1fa130 View commit details
    Browse the repository at this point in the history

  2. Update apps/files_trashbin/lib/Trashbin.php 

    Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Signed-off-by: danial rahimy <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy @Fenn-CS
    danialRahimy and Fenn-CS authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    b55f595 View commit details
    Browse the repository at this point in the history

  3. Update apps/files_trashbin/lib/Trashbin.php 

    Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Signed-off-by: danial rahimy <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy @Fenn-CS
    danialRahimy and Fenn-CS authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    863dd39 View commit details
    Browse the repository at this point in the history

  4. Update apps/files_trashbin/lib/Trashbin.php 

    Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Signed-off-by: danial rahimy <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy @Fenn-CS
    danialRahimy and Fenn-CS authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    a766334 View commit details
    Browse the repository at this point in the history

  5. Update apps/files_trashbin/lib/Trashbin.php 

    Co-authored-by: F. E Noel Nfebe <fenn25.fn@gmail.com>
Signed-off-by: danial rahimy <48244647+danialRahimy@users.noreply.github.com>
    @danialRahimy @Fenn-CS
    danialRahimy and Fenn-CS authored Aug 20, 2023
    Configuration menu
    Copy the full SHA
    2186f0d View commit details
    Browse the repository at this point in the history