Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor OC\Server::getContactsManager #40119

Merged

Conversation

summersab
Copy link
Contributor

This PR refactors the deprecated method OC\Server::getContactsManager and replaces it with OC\Server::get(\OCP\Contacts\IManager::class) throughout the entire NC codebase (excluding ./apps and ./3rdparty).

Additionally, where necessary, the \OCP\Contacts\IManager class is imported via the use directive.

@summersab summersab force-pushed the refactor/OC-Server-getContactsManager branch from 507bc6e to bc069d0 Compare August 30, 2023 01:32
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com>
@summersab summersab force-pushed the refactor/OC-Server-getContactsManager branch from bc069d0 to 29d70d6 Compare August 30, 2023 02:28
@solracsf solracsf added the 3. to review Waiting for reviews label Aug 30, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Aug 30, 2023
@summersab
Copy link
Contributor Author

Just commenting to ask if someone could re-run the GitHub actions on this one. Thanks!

@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
This was referenced Nov 6, 2023
This was referenced Nov 14, 2023
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
This was referenced Mar 12, 2024
This was referenced Mar 20, 2024
@skjnldsv skjnldsv mentioned this pull request Mar 28, 2024
81 tasks
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 30 Mar 28, 2024
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv requested review from artonge, come-nc, a team and sorbaugh and removed request for a team May 30, 2024 12:31
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels May 30, 2024
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
@skjnldsv skjnldsv merged commit 22f1854 into nextcloud:master May 30, 2024
142 of 153 checks passed
@blizzz blizzz mentioned this pull request Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants