Multiple bug fix in users list #40428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
artonge
commented
Sep 14, 2023
artonge
commented
- Do not display userCount when it is equal to 0
- Reset loading state on UserRow mount
- Do not preload potential manager list on UserRow mount
- Do not manipulate userCount when it is equal to 0
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
added
bug
3. to review
Signed-off-by: Louis Chemineau <louis@chmn.me>
artonge
force-pushed
the
artonge/fix/users_list_bugs
branch
from
6e98fe4
to
617a9e8
Compare
Pytal
force-pushed
the
artonge/fix/users_list_bugs
branch
2 times, most recently
from
07a525f
to
15d4a36
Compare
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Pytal
force-pushed
the
artonge/fix/users_list_bugs
branch
from
15d4a36
to
58229ad
Compare
|
Pushed a ux fix to show initial loading state of managers |
Pytal
approved these changes
Sep 15, 2023
artonge
changed the title
artonge
requested review from
a team,
susnux and
szaimen
and removed request for
a team
susnux
approved these changes
Sep 15, 2023
|
@Pytal Could you backport this to stable27? Not all commits will be needed I think but some of them applies the same I think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.