Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a message for app updates trough occ when no updates available #40538

Merged
merged 1 commit into from
Feb 24, 2024
Merged

Add a message for app updates trough occ when no updates available #40538

merged 1 commit into from
Feb 24, 2024

Conversation

solracsf
Copy link
Member

@solracsf solracsf commented Sep 20, 2023 •
edited
Loading

Summary

Return a message when no updates are available or have been found.

Can be useful to both inform the user that updates have been performed but none found and for scripting, instead of an empty output (and return 0).

# occ app:update contacts
contacts is up-to-date or no updates could be found

# occ app:update --all
All apps are up-to-date or no updates could be found

Checklist

@solracsf solracsf added the 3. to review Waiting for reviews label Sep 20, 2023
@solracsf solracsf added this to the Nextcloud 28 milestone Sep 20, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 20, 2023
View reviewed changes
core/Command/App/Update.php Fixed Show fixed Hide fixed
core/Command/App/Update.php Fixed Show fixed Hide fixed
@solracsf solracsf force-pushed the occAppUpdatesReturn branch 2 times, most recently from 13a70f6 to 8f6421f Compare September 20, 2023 15:31
@solracsf solracsf changed the title Add a return message for app updates trough occ when no updates available Add a message for app updates trough occ when no updates available Sep 21, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@skjnldsv skjnldsv requested review from a team, blizzz, Fenn-CS, sorbaugh and come-nc and removed request for a team February 23, 2024 20:49
@solracsf @skjnldsv
Add a return message for app updates trough occ
6dfe3c9 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Handle single and all apps

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>

Rewrite logic

Fix psalm

Fix psalm

Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2024
@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@skjnldsv skjnldsv merged commit 167d0d1 into master Feb 24, 2024
159 of 160 checks passed
@skjnldsv skjnldsv deleted the occAppUpdatesReturn branch February 24, 2024 10:25
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fenn-CS Fenn-CS Fenn-CS approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@blizzz blizzz Awaiting requested review from blizzz blizzz was automatically assigned from nextcloud/server-backend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-backend

@come-nc come-nc Awaiting requested review from come-nc

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish enhancement feature: apps management feature: install and update feature: occ
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
5 participants
@solracsf @Fenn-CS @skjnldsv @joshtrichards @blizzz