Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(SpeechToText): Allow providers to declare a dynamic ID instead of using className #41087

Merged
merged 2 commits into from
Dec 19, 2023
Merged

enh(SpeechToText): Allow providers to declare a dynamic ID instead of using className #41087

merged 2 commits into from
Dec 19, 2023

Conversation

marcelklehr
Copy link
Member

@marcelklehr marcelklehr commented Oct 24, 2023 •
edited by bigcat88
Loading

this allows AppAPI to register anonymous classes as SpeechToText providers

see nextcloud/app_api#60

Checklist

@marcelklehr
Copy link
Member Author

(I'm sort of sad about the beauty we lose with this, but alas)

@andrey18106 andrey18106 mentioned this pull request Oct 25, 2023
Closed
6 tasks
@solracsf solracsf added this to the Nextcloud 28 milestone Oct 27, 2023
@skjnldsv skjnldsv mentioned this pull request Nov 1, 2023
Merged
This was referenced Nov 6, 2023
Merged
Merged
This was referenced Nov 14, 2023
Merged
Merged
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@marcelklehr
enh(SpeechToText): Allow providers to declare a dynamic ID instead of…
928fee8 
… using className

this allows AppAPI to register anonymous classes as SpeechToText providers

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
@marcelklehr marcelklehr added the 3. to review Waiting for reviews label Dec 19, 2023
@marcelklehr
Copy link
Member Author

Please review

juliushaertl
juliushaertl approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good 👍

@marcelklehr
Update autoloaders
6f0b192 
Signed-off-by: Marcel Klehr <mklehr@gmx.net>
julien-nc
julien-nc approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@julien-nc julien-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐘

@marcelklehr marcelklehr merged commit 9327e36 into master Dec 19, 2023
50 checks passed
@marcelklehr marcelklehr deleted the enh/stt-provider-with-id branch December 19, 2023 14:29
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@julien-nc julien-nc julien-nc approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@andrey18106 andrey18106 andrey18106 approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
7 participants
@marcelklehr @juliushaertl @julien-nc @bigcat88 @andrey18106 @blizzz @solracsf