-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate code integrity to SetupCheck API #41312
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 6, 2023
come-nc
force-pushed
the
feat/migrate-code-integrity-check
branch
from
January 9, 2024 16:53
251eeed
to
276362a
Compare
come-nc
force-pushed
the
feat/migrate-code-integrity-check
branch
from
January 11, 2024 11:19
905adaa
to
69cd094
Compare
come-nc
changed the base branch from
master
to
enh/add-rich-object-support-to-setupchecks
January 11, 2024 11:20
come-nc
force-pushed
the
enh/add-rich-object-support-to-setupchecks
branch
from
January 11, 2024 13:03
dae9fa2
to
e884ffd
Compare
Base automatically changed from
enh/add-rich-object-support-to-setupchecks
to
master
January 11, 2024 16:15
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
…check Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Did not find a way to get a valid token from SetupCheck Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
force-pushed
the
feat/migrate-code-integrity-check
branch
from
January 15, 2024 10:50
540c82c
to
c998680
Compare
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
come-nc
added
21-feedback
3. to review
Waiting for reviews
and removed
2. developing
Work in progress
21-feedback
labels
Jan 15, 2024
come-nc
requested review from
nickvergessen,
susnux,
a team,
ArtificialOwl and
blizzz
and removed request for
a team
January 15, 2024 13:10
artonge
approved these changes
Jan 15, 2024
Altahrim
approved these changes
Jan 15, 2024
ArtificialOwl
approved these changes
Jan 15, 2024
blizzz
added
4. to release
Ready to be released and/or waiting for tests to finish
and removed
3. to review
Waiting for reviews
labels
Jan 15, 2024
4 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate code integrity check to new setup check API, but we need to figure out how to avoid a regression here
TODO
Checklist