-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dont reuse etag for folders marked explicitly unscanned #41327
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icewind1991
force-pushed
the
dont-reuse-metadata-unscanned
branch
from
November 7, 2023 15:53
4b28d58
to
c052feb
Compare
icewind1991
force-pushed
the
dont-reuse-metadata-unscanned
branch
3 times, most recently
from
November 22, 2023 15:39
4a8173c
to
d9aa466
Compare
Fix confirmed working by customer |
icewind1991
force-pushed
the
dont-reuse-metadata-unscanned
branch
from
December 4, 2023 15:38
d9aa466
to
e4374ec
Compare
icewind1991
requested review from
come-nc,
a team,
Fenn-CS and
sorbaugh
and removed request for
a team
December 4, 2023 15:40
/backport to stable27 |
/backport to stable26 |
come-nc
approved these changes
Dec 5, 2023
@icewind1991 backport to stable28 as well no? |
Fenn-CS
reviewed
Dec 6, 2023
Fenn-CS
reviewed
Dec 6, 2023
Fenn-CS
approved these changes
Dec 6, 2023
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…ning Signed-off-by: Robin Appelman <robin@icewind.nl>
/backport to stable28 |
icewind1991
force-pushed
the
dont-reuse-metadata-unscanned
branch
from
January 31, 2024 17:06
e4374ec
to
b777304
Compare
This was referenced Jan 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Speculated issue:
files_external:notify
is running marking the parent folder of any created file with a size of -1A use case that might trigger this is an external smb storage where the underlying fs doesn't change folder mtime as we expect but "files_external:notify" is being used to process external file changes.
I was able to reproduce this with manual
touch
ing to "unchange" the folder mtime a few times but then something changed and I can't anymore...