Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(global-search): Fix documented default config value #41382

Closed
wants to merge 1 commit into from
Closed

fix(global-search): Fix documented default config value #41382

wants to merge 1 commit into from

Conversation

nickvergessen
Copy link
Member

Checklist

@nickvergessen
fix(global-search): Fix documented default config value
e48c615 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Nov 10, 2023
@nickvergessen nickvergessen self-assigned this Nov 10, 2023
jospoortvliet
jospoortvliet approved these changes Nov 10, 2023
View reviewed changes
Copy link
Member

@jospoortvliet jospoortvliet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐘 ✨

@blizzz
Copy link
Member

blizzz commented Nov 10, 2023

So i was rightfully confused about the naming and value :)

This was referenced Nov 13, 2023
Merged
Merged
@blizzz blizzz mentioned this pull request Nov 20, 2023
Merged
5 tasks
@blizzz blizzz modified the milestones: Nextcloud 28, Nextcloud 29 Nov 23, 2023
@nickvergessen nickvergessen deleted the bugfix/noid/fix-default-config-value branch December 1, 2023 06:59
@skjnldsv skjnldsv removed this from the Nextcloud 29 milestone Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jospoortvliet jospoortvliet jospoortvliet approved these changes

@blizzz blizzz blizzz approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews feature: search
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nickvergessen @blizzz @jospoortvliet @skjnldsv