-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix search providers icons #41432
Fix search providers icons #41432
Conversation
CI failure unrelated |
@@ -221,6 +221,10 @@ private function fetchIcon(string $appId, string $providerId): string { | |||
[$appId, 'app.svg'], | |||
['core', 'places/default-app-icon.svg'], | |||
]; | |||
if ($appId === 'settings' && $providerId === 'users') { | |||
// The file /apps/settings/users.svg if already used in black version by user menu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
// The file /apps/settings/users.svg if already used in black version by user menu | |
// The file /apps/settings/users.svg is already used in black version by user menu |
Typo maybe? Or I do not understand the comment.
But still I do not understand the comment I think.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, typo…
We are using /apps/settings/users.svg
as an icon in the user menu on top right. In the menu, we need a black icon.
But for search, we need a white version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must these icons have the same name? Can't both colors be present? to avoid this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Must these icons have the same name?
My hack avoid this. The new icon is white and we keep the old one
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
cf11ebe
to
79d1e40
Compare
Related to advanced search