Migrate forwarded for headers check

[come-nc]

• See Migrate remaining setup checks to new API #41364

Summary

Migrate forwarded for headers check to new SetupCheck API.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required
• Backports requested where applicable (ex: critical bugfixes)

[come-nc]

There were 5 errors:
463	
464	1) OCA\Settings\Tests\ForwardedForHeadersTest::testForwardedForHeadersWorking with data set "trusted proxy, remote addr is trusted proxy, x-forwarded-for working" (array('1.1.1.1'), '1.1.1.1', '2.2.2.2', 'success')
465	TypeError: OCA\Settings\Tests\ForwardedForHeadersTest::OCA\Settings\Tests\{closure}(): Argument #2 ($replace) must be of type array, string given, called in phar:///usr/local/bin/phpunit/phpunit/Framework/MockObject/Stub/ReturnCallback.php on line 32
466	
467	/drone/src/apps/settings/tests/SetupChecks/ForwardedForHeadersTest.php:51
468	/drone/src/apps/settings/lib/SetupChecks/ForwardedForHeaders.php:82
469	/drone/src/apps/settings/tests/SetupChecks/ForwardedForHeadersTest.php:85
470	
471	2) OCA\Settings\Tests\Settings\Admin\SharingTest::testGetFormWithoutExcludedGroups
472	ArgumentCountError: Too few arguments to function OCA\Settings\Settings\Admin\Sharing::__construct(), 4 passed in /drone/src/apps/settings/tests/Settings/Admin/SharingTest.php on line 68 and exactly 7 expected
473	
474	/drone/src/apps/settings/lib/Settings/Admin/Sharing.php:48
475	/drone/src/apps/settings/tests/Settings/Admin/SharingTest.php:68
476	
477	3) OCA\Settings\Tests\Settings\Admin\SharingTest::testGetFormWithExcludedGroups
478	ArgumentCountError: Too few arguments to function OCA\Settings\Settings\Admin\Sharing::__construct(), 4 passed in /drone/src/apps/settings/tests/Settings/Admin/SharingTest.php on line 68 and exactly 7 expected
479	
480	/drone/src/apps/settings/lib/Settings/Admin/Sharing.php:48
481	/drone/src/apps/settings/tests/Settings/Admin/SharingTest.php:68
482	
483	4) OCA\Settings\Tests\Settings\Admin\SharingTest::testGetSection
484	ArgumentCountError: Too few arguments to function OCA\Settings\Settings\Admin\Sharing::__construct(), 4 passed in /drone/src/apps/settings/tests/Settings/Admin/SharingTest.php on line 68 and exactly 7 expected
485	
486	/drone/src/apps/settings/lib/Settings/Admin/Sharing.php:48
487	/drone/src/apps/settings/tests/Settings/Admin/SharingTest.php:68
488	
489	5) OCA\Settings\Tests\Settings\Admin\SharingTest::testGetPriority
490	ArgumentCountError: Too few arguments to function OCA\Settings\Settings\Admin\Sharing::__construct(), 4 passed in /drone/src/apps/settings/tests/Settings/Admin/SharingTest.php on line 68 and exactly 7 expected
491	
492	/drone/src/apps/settings/lib/Settings/Admin/Sharing.php:48
493	/drone/src/apps/settings/tests/Settings/Admin/SharingTest.php:68
494	
495	--
496	
497	There was 1 failure:
498	
499	1) OCA\Settings\Tests\ForwardedForHeadersTest::testForwardedHostPresentButTrustedProxiesEmpty
500	Failed asserting that two strings are equal.
501	--- Expected
502	+++ Actual
503	@@ @@
504	-'warning'
505	+'error'
506	
507	/drone/src/apps/settings/tests/SetupChecks/ForwardedForHeadersTest.php:137

Failure related

[come-nc]

New drone errors are unrelated.