fix(dav): Prioritize timezone from core/login #41866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
ChristophWurst
requested review from
miaulalala and
tcitworld
as code owners
|
/backport to stable28 |
miaulalala
approved these changes
Nov 29, 2023
tcitworld
approved these changes
Nov 29, 2023
| 'core', | ||
| 'timezone', | ||
| ); | ||
| if ($fromConfig !== '') { |
There was a problem hiding this comment.
I wanted to say that the value might not be a valid timezone ID, but someone fixed that a couple of months ago. #36001 🙈
Older values might still be bad though, as I didn't add a repair step.
There was a problem hiding this comment.
Good enough IMO. The value is set at every login.
ChristophWurst
added
4. to release
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The DAV app tries to guess a user's timezone from the calendar timezones and the availability settings. It turns out Nextcloud already tracks a timezone, set when a user logs in. Let's use that as primary source, then fall back to calendar timezones and availability timezone.
How to test
Master: calendar timezone is used
Here: login timezone is used
In the long run we should probably only set, not update the timezone at login, and make the timezone configurable via the personal settings.
Checklist