Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(theming): Fix color inverted icons based on theming and dark mode #41920

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[stable28] fix(theming): Fix color inverted icons based on theming and dark mode #41920

merged 2 commits into from
Nov 30, 2023

Conversation

nickvergessen
Copy link
Member

Backport of #41855

@nickvergessen
fix(theming): Fix color inverted icons based on theming and dark mode
217753d 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Fix more active entry icons
32ec76e 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen added this to the Nextcloud 28 milestone Nov 30, 2023
@nickvergessen nickvergessen self-assigned this Nov 30, 2023
szaimen
szaimen approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but didnt test

@szaimen szaimen merged commit 0561b11 into stable28 Nov 30, 2023
48 of 50 checks passed
@szaimen szaimen deleted the backport/41855/stable28 branch November 30, 2023 10:10
@blizzz blizzz mentioned this pull request Nov 30, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndyScherzinger AndyScherzinger AndyScherzinger approved these changes

@szaimen szaimen szaimen approved these changes

@susnux susnux Awaiting requested review from susnux

Assignees

@nickvergessen nickvergessen

Labels
3. to review Waiting for reviews accessibility feature: theming
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.
3 participants
@nickvergessen @AndyScherzinger @szaimen