fix(dav): allow any throwable in logException #41985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pulsejet
added
bug
3. to review
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
susnux
requested review from
a team,
ArtificialOwl and
icewind1991
and removed request for
a team
susnux
changed the title
pulsejet
force-pushed
the
pulsejet/fix-log-exception
branch
from
6c8b9e4
to
a3b617f
Compare
susnux
approved these changes
Dec 3, 2023
Altahrim
approved these changes
Dec 4, 2023
If a TypeError is passed here, it in turn causes a TypeError which kills the rendering of the error page. Signed-off-by: Varun Patil <varunpatil@ucla.edu>
blizzz
force-pushed
the
pulsejet/fix-log-exception
branch
from
a3b617f
to
a205561
Compare
|
/backport to stable28 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a TypeError is passed here, it in turn causes a TypeError which kills the rendering of the error page.