fix: Also filter out undefined entries from the file list #42021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
juliushaertl
requested review from
AndyScherzinger,
ChristophWurst,
a team,
Fenn-CS,
sorbaugh and
emoral435
and removed request for
a team
|
/backport to stable28 |
AndyScherzinger
approved these changes
Dec 4, 2023
|
👍 Also the backport of the fix hasn't been picked up by the bot ye6t |
ChristophWurst
approved these changes
Dec 5, 2023
juliushaertl
force-pushed
the
bugfix/noid/fix-undefined-array-entries
branch
from
f0f7840
to
1583484
Compare
|
/compile |
5 tasks
|
Manually backported both in #42023 |
miaulalala
approved these changes
Dec 5, 2023
susnux
approved these changes
Dec 5, 2023
juliushaertl
force-pushed
the
bugfix/noid/fix-undefined-array-entries
branch
from
d88f1e4
to
7dc5cdc
Compare
|
/compile |
AndyScherzinger
force-pushed
the
bugfix/noid/fix-undefined-array-entries
branch
from
7dc5cdc
to
6ed4ea2
Compare
|
/compile amend / |
Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliushaertl
force-pushed
the
bugfix/noid/fix-undefined-array-entries
branch
from
6ed4ea2
to
8b5eeb1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I misread the cypress failure in #42006 which was actually related. This pr fixes that to also filter out undefined values from the list e.g. when a file was moved to another folder