Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix look of personal global credentials settings #42031

Merged
merged 1 commit into from
Dec 5, 2023
Merged

fix look of personal global credentials settings #42031

merged 1 commit into from
Dec 5, 2023

Conversation

szaimen
Copy link
Contributor

@szaimen szaimen commented Dec 5, 2023 •
edited
Loading

Close #41614

Before After
image image

@szaimen szaimen added enhancement design Design, UI, UX, etc. 2. developing Work in progress labels Dec 5, 2023
@szaimen szaimen added this to the Nextcloud 29 milestone Dec 5, 2023
@szaimen szaimen added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Dec 5, 2023
@szaimen szaimen marked this pull request as ready for review December 5, 2023 10:40
@szaimen szaimen requested review from jancborchardt, marcoambrosini, a team, Fenn-CS, sorbaugh and emoral435 and removed request for a team December 5, 2023 10:41
@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2023

/backport to stable28

@szaimen szaimen force-pushed the enh/41614/fix-personal-settings branch from 2fba7f2 to 76f9929 Compare December 5, 2023 10:42
@szaimen szaimen force-pushed the enh/41614/fix-personal-settings branch from 76f9929 to 42fc248 Compare December 5, 2023 11:43
@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2023

/compile amend /

@szaimen
fix look of personal global credentials settings
cafa805 
Signed-off-by: Simon L <szaimen@e.mail.de>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@szaimen szaimen force-pushed the enh/41614/fix-personal-settings branch from a5782e1 to cafa805 Compare December 5, 2023 12:57
@szaimen
Copy link
Contributor Author

szaimen commented Dec 5, 2023

CI failure unrelated

@szaimen szaimen disabled auto-merge December 5, 2023 16:27
@szaimen szaimen merged commit b0976e4 into master Dec 5, 2023
58 of 62 checks passed
@szaimen szaimen deleted the enh/41614/fix-personal-settings branch December 5, 2023 16:27
@szaimen szaimen mentioned this pull request Dec 6, 2023
Merged
@szaimen
Copy link
Contributor Author

szaimen commented Dec 6, 2023

#42058

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jancborchardt jancborchardt jancborchardt approved these changes

@marcoambrosini marcoambrosini marcoambrosini approved these changes

@Fenn-CS Fenn-CS Awaiting requested review from Fenn-CS Fenn-CS was automatically assigned from nextcloud/server-frontend

@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh was automatically assigned from nextcloud/server-frontend

@emoral435 emoral435 Awaiting requested review from emoral435 emoral435 was automatically assigned from nextcloud/server-frontend

Assignees
No one assigned
Labels
3. to review Waiting for reviews backport-request design Design, UI, UX, etc. enhancement
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.

[Bug]: External storage settings layout is mixed emptycontent + actual interface
3 participants
@szaimen @jancborchardt @marcoambrosini