enh(NavigationManager): Use ID as fallback for app
property of entries
#42055
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some apps like Talk do not use the appinfo for registering the navigation entries but using the NavigationManager directly. Those apps do not always set the app property of the navigation entry, in this cases it is currently not possible to use that entry for the default app.
To fix 99% of the cases the ID is now checked to be a valid and enabled app and if yes then use it as fallback.
Checklist