Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Let git ignore composer dev dependencies #42065

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 6, 2023

Summary

Do not trash the state when running composer install with dev dependencies.

Checklist

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added the 3. to review Waiting for reviews label Dec 6, 2023
@susnux susnux requested review from nickvergessen, ChristophWurst, a team, ArtificialOwl, icewind1991 and Fenn-CS and removed request for a team December 6, 2023 15:40
@@ -11,6 +11,7 @@
}
},
"autoload": {
"exclude-from-classmap": ["**/bamarni/composer-bin-plugin/**"],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that's fancy and as the biggest pain so far

@nickvergessen nickvergessen added this to the Nextcloud 29 milestone Dec 7, 2023
@nickvergessen nickvergessen merged commit 4f8c998 into master Dec 7, 2023
50 checks passed
@nickvergessen nickvergessen deleted the chore/ignore-dev-dependencies branch December 7, 2023 08:09
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants