Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enh(a11y): Add navigation labels #42077

Merged
merged 3 commits into from
Dec 7, 2023
Merged

enh(a11y): Add navigation labels #42077

merged 3 commits into from
Dec 7, 2023

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Dec 7, 2023

Summary

Checklist

@Pytal
enh(files): Add files navigation label
0167f67 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
enh(settings): Add apps and user management navigation labels
7c479aa 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal Pytal added 3. to review Waiting for reviews accessibility labels Dec 7, 2023
@Pytal Pytal added this to the Nextcloud 29 milestone Dec 7, 2023
@Pytal Pytal self-assigned this Dec 7, 2023
@Pytal
Copy link
Member Author

Pytal commented Dec 7, 2023

/compile /

@Pytal
Copy link
Member Author

Pytal commented Dec 7, 2023 •
edited by nickvergessen
Loading

/backport 0167f67,7c479aad512575f8f2712ac68d6a72bc5808b42e to stable28

@nextcloud-command
chore(assets): Recompile assets
cad0f58 
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@Pytal Pytal changed the title enh(files): Add files navigation label enh(a11y): Add navigation labels Dec 7, 2023
@Pytal Pytal enabled auto-merge December 7, 2023 01:18
nickvergessen
nickvergessen approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should make it a required prop on the component, so you can not write in-accessible stuff by default in the future?

@nickvergessen nickvergessen merged commit c41cbcf into master Dec 7, 2023
40 of 41 checks passed
@nickvergessen nickvergessen deleted the enh/a11y/app-nav-labels branch December 7, 2023 08:56
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 7, 2023
Merged
@Pytal Pytal mentioned this pull request Dec 7, 2023
Open
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@susnux susnux Awaiting requested review from susnux

@JuliaKirschenheuter JuliaKirschenheuter Awaiting requested review from JuliaKirschenheuter

@ShGKme ShGKme Awaiting requested review from ShGKme

Assignees

@Pytal Pytal

Labels
3. to review Waiting for reviews accessibility
Projects
None yet
Milestone
Nextcloud 29
Development

Successfully merging this pull request may close these issues.
4 participants
@Pytal @nickvergessen @skjnldsv @nextcloud-command