Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): Do not add drag handlers on rename #42242

Merged
merged 2 commits into from
Dec 13, 2023
Merged

fix(files): Do not add drag handlers on rename #42242

merged 2 commits into from
Dec 13, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 13, 2023

Summary

Do not add the drag handlers when renaming as otherwise you can not select text from the text input. So this now does not support dragging when renaming is active but this i - I think - the expected behavior.

Checklist

@susnux susnux added bug 3. to review Waiting for reviews files2vue labels Dec 13, 2023
@susnux
Copy link
Contributor Author

susnux commented Dec 13, 2023

/backport to stable28

@susnux susnux force-pushed the fix/files-drag-when-rename-file branch from db314dd to 6de9404 Compare December 13, 2023 15:35
emoral435
emoral435 approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looked over the code and tested on dev setup - LGTM

@susnux @emoral435
fix(files): Do not add drag and drop listeners when renaming a file
9dbaf7a 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux @emoral435
chore: Compile assets
9e56c78 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@emoral435 emoral435 force-pushed the fix/files-drag-when-rename-file branch from 6de9404 to 9e56c78 Compare December 13, 2023 17:56
@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 13, 2023
@emoral435 emoral435 merged commit 20932c8 into master Dec 13, 2023
42 checks passed
@emoral435 emoral435 deleted the fix/files-drag-when-rename-file branch December 13, 2023 18:09
@susnux
Copy link
Contributor Author

susnux commented Dec 14, 2023

/backport 59b9331 to stable28

@susnux susnux mentioned this pull request Dec 14, 2023
Merged
@skjnldsv
Copy link
Member

@susnux what about

server/apps/files/src/components/FileEntryGrid.vue

Lines 31 to 35 in 4db0388

@dragover="onDragOver"
@dragleave="onDragLeave"
@dragstart="onDragStart"
@dragend="onDragEnd"
@drop="onDrop">
🙈

@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artonge artonge artonge approved these changes

@emoral435 emoral435 emoral435 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@skjnldsv skjnldsv Awaiting requested review from skjnldsv skjnldsv is a code owner

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Not possible change cursor or focus of file name by mouse on Firefox
4 participants
@susnux @skjnldsv @artonge @emoral435