Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): changed h3 elements to h2 #42290

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix(dashboard): changed h3 elements to h2 #42290

merged 1 commit into from
Dec 15, 2023

Conversation

emoral435
Copy link
Contributor

@emoral435 emoral435 commented Dec 14, 2023

☑️ Resolves #42268

🖼️ Screenshots

🏚️ Before 🏡 After
image image

🚧 Summary

Changed the h3 headings in the customize modal popup to be h2

Checklist

Copy link
Member

@Pytal Pytal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than class removal

Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 self-assigned this Dec 15, 2023
@emoral435 emoral435 added the 3. to review Waiting for reviews label Dec 15, 2023
@emoral435 emoral435 merged commit ce0dc03 into master Dec 15, 2023
41 checks passed
@emoral435 emoral435 deleted the enh/h3-to-h2 branch December 15, 2023 01:32
@susnux
Copy link
Contributor

susnux commented Dec 15, 2023

/backport to stable28

@emoral435 emoral435 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Dec 15, 2023
@blizzz blizzz mentioned this pull request Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9.1.3.1a/2.2 Modal Dialog "Customize" - It is recommended to change the "h3" heading to "h2" heading.
3 participants