Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ooo): add new ooo status with new emoji #42304

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix(ooo): add new ooo status with new emoji #42304

merged 1 commit into from
Dec 18, 2023

Conversation

miaulalala
Copy link
Contributor

@miaulalala miaulalala commented Dec 15, 2023 •
edited
Loading

Summary

The OOO status set the predefined vacation status which is awkward when you're out sick 🤧

Before After
image image

It also solves the issue of an automation not running at all when the last_run timestamp is in the future.

Checklist

@miaulalala
Copy link
Contributor Author

/backport to stable28

@miaulalala miaulalala requested review from GretaD, ChristophWurst, a team, ArtificialOwl, icewind1991 and Altahrim and removed request for a team December 15, 2023 10:19
GretaD
GretaD approved these changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@GretaD GretaD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks better

@miaulalala miaulalala changed the title fix(ooo): add new ooo status with new emoji fix(ooo): add new ooo status with new emoji and fix last_run timestamp issue Dec 15, 2023
@miaulalala miaulalala mentioned this pull request Dec 15, 2023
Merged
4 tasks
nickvergessen
nickvergessen requested changes Dec 18, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good apart from the version in the docs

@miaulalala miaulalala changed the title fix(ooo): add new ooo status with new emoji and fix last_run timestamp issue fix(ooo): add new ooo status with new emoji Dec 18, 2023
@miaulalala
Copy link
Contributor Author

All good apart from the version in the docs

This is ok to go in to 28.0.1

@miaulalala
fix(ooo): add new ooo status with new emoji
fc4ef61 
Signed-off-by: Anna Larch <anna@nextcloud.com>
nickvergessen
nickvergessen approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM didn't test

@miaulalala
Copy link
Contributor Author

@blizzz approval for 28.0.1

@nickvergessen nickvergessen merged commit f7bead0 into master Dec 18, 2023
49 of 50 checks passed
@nickvergessen nickvergessen deleted the fix/emoji-ooo-status branch December 18, 2023 11:41
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Dec 18, 2023
Merged
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@GretaD GretaD GretaD approved these changes

@bigcat88 bigcat88 bigcat88 approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@ArtificialOwl ArtificialOwl Awaiting requested review from ArtificialOwl ArtificialOwl was automatically assigned from nextcloud/server-backend

@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 was automatically assigned from nextcloud/server-backend

@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim was automatically assigned from nextcloud/server-backend

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: OOO always saves the 🌴 emoji
4 participants
@miaulalala @nickvergessen @GretaD @bigcat88