Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theming): Adjust dark high contrast to fulfill WCAG 2.1 AAA contrast #42329

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

susnux
Copy link
Contributor

@susnux susnux commented Dec 16, 2023

Summary

This adds high contrast support for the theming util and unit tests and adjust the high contrast dark theme to fulfill WCAG 2.1 AAA color contrast for text.

Checklist

@susnux susnux force-pushed the fix/dark-theme-and-element-colors branch from ee63ecd to 734f0dc Compare December 16, 2023 13:11
@susnux susnux force-pushed the fix/dark-theme-and-element-colors branch from 734f0dc to 8dee78f Compare December 16, 2023 13:49
@emoral435 emoral435 force-pushed the fix/dark-theme-and-element-colors branch from 8dee78f to ae12a73 Compare December 18, 2023 16:25
Base automatically changed from fix/dark-theme-and-element-colors to master December 18, 2023 17:13
@susnux susnux added this to the Nextcloud 29 milestone Dec 18, 2023
@susnux
Copy link
Contributor Author

susnux commented Dec 18, 2023

/backport to stable28

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks!

JuliaKirschenheuter

This comment was marked as resolved.

@susnux

This comment was marked as resolved.

@susnux
Copy link
Contributor Author

susnux commented Dec 19, 2023

@JuliaKirschenheuter I adjusted all themes for the color-success and color-error and added a test case for the border contrast. Should be good now.

@JuliaKirschenheuter
Copy link
Contributor

@JuliaKirschenheuter I adjusted all themes for the color-success and color-error and added a test case for the border contrast. Should be good now.

That works now, thanks a lot!

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
…put border colors

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@emoral435 emoral435 merged commit e8275ab into master Dec 19, 2023
50 checks passed
@emoral435 emoral435 deleted the fix/highcontrast branch December 19, 2023 17:34
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@susnux
Copy link
Contributor Author

susnux commented Dec 21, 2023

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants