enh(breadcrumbs): removed unnecessary aria label

[emoral435]

☑️ This fix depends on nextcloud-libraries/nextcloud-vue#4973 to be merged first! Resolves #42265

##🚧 Summary
This is a quick review, for a small change due to the changes made in a nextcloud component. As the aria label is being set on the component, this is redundant, as the section that needs the aria label is set on the correct element in the new version of the component.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Screenshots before/after for front-end changes
• Documentation (manuals or wiki) has been updated or is not required (NA)
• Backports requested where applicable (ex: critical bugfixes)

[emoral435]

/backport to 28

[ShGKme]

I think we should also specify aria-label on NcBreadcrumbs so it will be clear that this navigation is the current directory path.

But I'm not sure we should add the title for each button.

It may make sense for the first button because it has only an icon. And maybe for the last one because it has a different value with Reload current directory.

But it may overload a user giving to much information. I'd even consider removing Reload current directory, because via screen reader it is known that this button is a link for the current directory.

[skjnldsv]

🐘

[emoral435]

@ShGKme So, I changed the method name to titleForSection, added an aria label to the nav wrapper that is the NcBreadCrumbs component, and removed the title attribute from all the breadcrumbs except the home icon!

[ShGKme]

Need to check how it is read with other than NVDA screen readers when there as both Text content and Title in navigation links.

With NVDA either title or text content is read and works fine.

[JuliaKirschenheuter]

please check the console

[emoral435]

Should be fixed now! Just added t as a method, forgot to do so before :)

[JuliaKirschenheuter]

Works now, thank you!

Sorry, i know that it is a bit too late but i think it would be better to remove native tooltips from breadcrumbs (all title attrs) because then we will face with a problem again: tooltips are there but there is no other way to discover this information besides mouse over. But i can create an issue for that

[JuliaKirschenheuter]

#42379 (review) -> #42460

[backportbot-nextcloud]

The backport to 28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout 28
git pull origin 28

# Create the new backport branch
git checkout -b fix/foo-28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport