Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh FileList on current folder update #42382

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

Raudius
Copy link
Contributor

@Raudius Raudius commented Dec 19, 2023

Summary

This PR subscribes the FileList view to the file-updated event. If the file updated matches the current folder it re-fetches the current view.

Checklist

@skjnldsv
Copy link
Member

/backport to stable28

@Raudius
Copy link
Contributor Author

Raudius commented Dec 20, 2023

/compile

@Raudius Raudius force-pushed the feature/filelist_refresh_current_folder_on_update branch from b88cf8f to 9cc8c68 Compare December 20, 2023 12:37
@skjnldsv skjnldsv requested review from a team, Fenn-CS and sorbaugh and removed request for a team December 21, 2023 08:46
@hschletz
Copy link
Contributor

This PR won't work because the function names mismatch: subscribe() uses "onUpdateNode", but actual name is "onUpdatedNode".

@Raudius Raudius force-pushed the feature/filelist_refresh_current_folder_on_update branch from 1d5617e to b3bf1cf Compare January 10, 2024 23:55
@Raudius
Copy link
Contributor Author

Raudius commented Jan 10, 2024

Nice catch @hschletz! I have now fixed it and tested again using my app which already integrates the changes:

https://github.com/Raudius/files_scripts/blob/master/src/files.ts#L10

@skjnldsv skjnldsv requested a review from a team January 11, 2024 08:29
@Raudius Raudius requested a review from artonge January 11, 2024 13:39
@artonge
Copy link
Contributor

artonge commented Jan 11, 2024

@Raudius please rebase and compile again, then it will be good to merge :)

Raudius and others added 2 commits January 11, 2024 15:39
Signed-off-by: Raul Ferreira <r.ferreira.fuentes@gmail.com>
Co-authored-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
Signed-off-by: Raul Ferreira Fuentes <Raudius@users.noreply.github.com>
@Raudius Raudius force-pushed the feature/filelist_refresh_current_folder_on_update branch from 75d22dc to bced164 Compare January 11, 2024 14:41
@Raudius
Copy link
Contributor Author

Raudius commented Jan 11, 2024

/compile

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 11, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
Signed-off-by: Raul Ferreira <r.ferreira.fuentes@gmail.com>
@Raudius Raudius force-pushed the feature/filelist_refresh_current_folder_on_update branch from bced164 to cf415bf Compare January 11, 2024 14:56
@skjnldsv skjnldsv merged commit 10b9b20 into master Jan 11, 2024
40 of 41 checks passed
@skjnldsv skjnldsv deleted the feature/filelist_refresh_current_folder_on_update branch January 11, 2024 15:19
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish feature: files technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refresh current folder view
4 participants