Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(files): move focus to sidebar on open #42444

Merged
merged 3 commits into from
Feb 8, 2024
Merged

fix(files): move focus to sidebar on open #42444

merged 3 commits into from
Feb 8, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Dec 22, 2023 •
edited
Loading

Summary

See commits for details.

See nextcloud-libraries/nextcloud-vue#5219 for screenshots

Checklist

@ShGKme ShGKme added 2. developing Work in progress feature: file sidebar Related to the file sidebar component accessibility labels Dec 22, 2023
@ShGKme ShGKme added this to the Nextcloud 29 milestone Dec 22, 2023
@ShGKme ShGKme self-assigned this Dec 22, 2023
@ShGKme ShGKme force-pushed the fix/41877/files--move-focus-to-sidebar-on-open branch from 8656a08 to 027868e Compare February 7, 2024 01:38
@ShGKme ShGKme force-pushed the fix/41877/files--move-focus-to-sidebar-on-open branch from 027868e to 4ec2ba6 Compare February 7, 2024 01:44
@ShGKme ShGKme mentioned this pull request Feb 7, 2024
Merged
2 tasks
JuliaKirschenheuter
JuliaKirschenheuter approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great too! Thank you!

@JuliaKirschenheuter JuliaKirschenheuter marked this pull request as ready for review February 7, 2024 09:25
@JuliaKirschenheuter
Copy link
Contributor

/compile /

@emoral435 emoral435 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 7, 2024
emoral435
emoral435 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@emoral435 emoral435 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of a minor nitpick, LGTM! 🐘💙

apps/files/src/views/Sidebar.vue Outdated Show resolved Hide resolved
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 7, 2024 •
edited
Loading

/compile /

This PR requires @nextcloud/vue update first

@ShGKme ShGKme force-pushed the fix/41877/files--move-focus-to-sidebar-on-open branch 2 times, most recently from 608e7d5 to a70c3de Compare February 7, 2024 15:35
skjnldsv
skjnldsv reviewed Feb 7, 2024
View reviewed changes
apps/files/src/components/FileEntry/FileEntryActions.vue Outdated
@@ -53,6 +53,7 @@
:close-after-click="!isMenu(action.id)"
:data-cy-files-list-row-action="action.id"
:is-menu="isMenu(action.id)"
:aria-label="mountType === 'shared' && action.id === 'sharing-status' ? action.title([source]) : actionDisplayName(action)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems really specific, where is this coming from and what does it have to do with that PR? :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the next one line (title prop) and the content of the button 7 lines below. I can move it to a new PR, but a button must have a label or text.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@skjnldsv moved to another PR

skjnldsv
skjnldsv requested changes Feb 7, 2024
View reviewed changes
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

@ShGKme
fix(files): do not disable action on load to keep focus
eb01e74 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(files): focus sidebar tab on tab or file change
a0a1362 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
chore(assets): Recompile assets
17c9f73 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 7, 2024

/backport to stable28

@ShGKme ShGKme force-pushed the fix/41877/files--move-focus-to-sidebar-on-open branch from a70c3de to 17c9f73 Compare February 7, 2024 23:05
@ShGKme
Copy link
Contributor Author

ShGKme commented Feb 8, 2024

  • Rebased onto master with required @nextcloud/vue changes
  • Fixing labeling of inline files actions is moved to another PR

@skjnldsv skjnldsv merged commit 66bd27f into master Feb 8, 2024
85 checks passed
@skjnldsv skjnldsv deleted the fix/41877/files--move-focus-to-sidebar-on-open branch February 8, 2024 07:57
@JuliaKirschenheuter
Copy link
Contributor

/backport to stable28

@backportbot backportbot bot mentioned this pull request Feb 8, 2024
Merged
2 tasks
artonge pushed a commit that referenced this pull request Feb 8, 2024
@skjnldsv @artonge
Merge pull request #42444 from nextcloud/fix/41877/files--move-focus-…
a4f338c 
…to-sidebar-on-open
@blizzz blizzz mentioned this pull request Mar 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emoral435 emoral435 emoral435 approved these changes

@JuliaKirschenheuter JuliaKirschenheuter JuliaKirschenheuter approved these changes

@skjnldsv skjnldsv skjnldsv approved these changes

@Pytal Pytal Awaiting requested review from Pytal

@susnux susnux Awaiting requested review from susnux

Assignees

@ShGKme ShGKme

Labels
3. to review Waiting for reviews accessibility feature: file sidebar Related to the file sidebar component
Projects
None yet
Milestone
Nextcloud 29
4 participants
@ShGKme @JuliaKirschenheuter @skjnldsv @emoral435