Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/files/42460/breadcrumb conditional rendering #42507

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

emoral435
Copy link
Contributor

☑️ Resolves #42460

🖼️ Screenshots

🏡 After
firefox_7h4YBek9ip

🚧 Summary
Removed the title attribute from all breadcrumb headers from all but the first and last breadcrumbs - the first having an aria label, and the last being differently titled than the rest

Checklist

@emoral435
Copy link
Contributor Author

/backport to stable28

Copy link
Contributor

@JuliaKirschenheuter JuliaKirschenheuter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good but not completely right

The last item should not have any title, it is just the same item as previous one

@emoral435 emoral435 force-pushed the fix/files/42460/breadcrumb-conditional-rendering branch from 5c5c037 to 870827b Compare January 2, 2024 17:37
@ShGKme ShGKme requested a review from skjnldsv January 2, 2024 23:39
Copy link
Member

@skjnldsv skjnldsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emoral435
Copy link
Contributor Author

Will wait to see what we choose to do going forward before making any more changes :)

@emoral435 emoral435 force-pushed the fix/files/42460/breadcrumb-conditional-rendering branch from 870827b to 287da22 Compare January 5, 2024 14:32
apps/files/src/components/BreadCrumbs.vue Outdated Show resolved Hide resolved
@emoral435 emoral435 force-pushed the fix/files/42460/breadcrumb-conditional-rendering branch from 287da22 to bc2a877 Compare January 5, 2024 15:49
@emoral435 emoral435 requested a review from ShGKme January 5, 2024 15:49
@emoral435
Copy link
Contributor Author

Cleaned up the component a bit, I was making it a bit sloppier than it needed to be, to be honest!

@emoral435 emoral435 dismissed JuliaKirschenheuter’s stale review January 5, 2024 17:09

approved change within messages on Talk :)

Signed-off-by: Eduardo Morales <emoral435@gmail.com>
@emoral435 emoral435 force-pushed the fix/files/42460/breadcrumb-conditional-rendering branch from bc2a877 to 2554419 Compare January 5, 2024 17:10
@emoral435 emoral435 merged commit 2e87874 into master Jan 5, 2024
41 checks passed
@emoral435 emoral435 deleted the fix/files/42460/breadcrumb-conditional-rendering branch January 5, 2024 17:31
@backportbot-nextcloud
Copy link

The backport to stable28 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable28
git pull origin stable28

# Create the new backport branch
git checkout -b fix/foo-stable28

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28

Error: Unknown error

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@emoral435
Copy link
Contributor Author

/ backport 2554419 to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BITV]: remove all native tooltips from breadcrumbs
4 participants