-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/files/42460/breadcrumb conditional rendering #42507
Fix/files/42460/breadcrumb conditional rendering #42507
Conversation
/backport to stable28 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good but not completely right
The last item should not have any title
, it is just the same item as previous one
5c5c037
to
870827b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will wait to see what we choose to do going forward before making any more changes :) |
870827b
to
287da22
Compare
287da22
to
bc2a877
Compare
Cleaned up the component a bit, I was making it a bit sloppier than it needed to be, to be honest! |
approved change within messages on Talk :)
Signed-off-by: Eduardo Morales <emoral435@gmail.com>
bc2a877
to
2554419
Compare
The backport to stable28 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable28
git pull origin stable28
# Create the new backport branch
git checkout -b fix/foo-stable28
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable28 Error: Unknown error More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
/ backport 2554419 to stable28 |
☑️ Resolves #42460
🖼️ Screenshots
🏡 After
🚧 Summary
Removed the title attribute from all breadcrumb headers from all but the first and last breadcrumbs - the first having an aria label, and the last being differently titled than the rest
Checklist