-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(files): fix unshare action and merge duplicate shares #42584
Conversation
a360f48
to
32e3a47
Compare
32e3a47
to
c9fd510
Compare
Would all the files be deleted? or would the not-shared files be deleted and shared files be unshared? I'm wondering if it makes sense to just show
We are moving away from "users" in the wording. So |
Technically not possible. We do not show actions if they only target a specific subset of the selection. Considering a selection with share and owned-files, it would shown neither options as none of the two actions can be executed on the current selection
Done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from design perspective but didnt test
6cbcfdb
to
022c2ee
Compare
Failure not related |
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
022c2ee
to
15ef58b
Compare
Fix unshare action
The delete action now properly adjust itself depending on the selectcion
Delete
Unshare
Delete and unshare
if shares and files are mixed in the selectioncc @nextcloud/designers for wording validation
Fix #14437
Merge duplicates shares in the views
The sharing views will group the same nodes coming from the same source⚠️
This can happen if a user share a folder with different groups and you're a member of them. The same file will appear multiple times in the
Shared with you
section.We ONLY MERGE entries with the same location on the user file system, which means, if you have two different shares but they are in different folders (moved) and therefore are matching different shares, we will NOT group them, and their actions will both target different shares.
cc @nextcloud/designers for wording validation and icon choice